Skip to content

Send saml logout response even when validation errors happen #14676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2025

Conversation

1livv
Copy link
Contributor

@1livv 1livv commented Mar 3, 2024

solves #14635

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 3, 2024
@jzheaux jzheaux self-assigned this Mar 6, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Mar 6, 2024

Thanks for the PR, @1livv. This is going to take a little bit more work to maintain backward compatibility and also ensure that the APIs progress naturally. I'll get back to you soon with recommendations.

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1livv! This is very helpful. I've left my feedback inline.

@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 6, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Apr 19, 2024

Hi, @1livv, are you able to make the requested changes?

@1livv
Copy link
Contributor Author

1livv commented Apr 19, 2024

Hey @jzheaux this slipped off my radar, i'll take a look in the next days.
Sorry for the delay

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 19, 2024
@jan-knoblich
Copy link

@1livv I'd be willing to take care of the change requests if you are ok with this

@1livv
Copy link
Contributor Author

1livv commented Aug 19, 2024

Yes, that would be great thank you @jan-knoblich !!

@jan-knoblich
Copy link

@1livv Could you Sync your repository with the main one? Otherwise I will have to create a new one. There are some changes that impact the changes in this PR
This explains how to sync: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@jzheaux
Copy link
Contributor

jzheaux commented Jun 5, 2025

@1livv and @jan-knoblich, I've rebased the PR, thanks for your patience.

Would either of you like to apply the listed changes? If I don't hear from you one way or the other by next week, I'll go ahead and provide a polish commit myself.

@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jun 5, 2025
@jzheaux jzheaux added this to the 7.0.x milestone Jun 5, 2025
1livv added 4 commits June 7, 2025 17:54
Signed-off-by: Liviu Gheorghe <[email protected]>
Signed-off-by: Liviu Gheorghe <[email protected]>
Signed-off-by: Liviu Gheorghe <[email protected]>
@jzheaux jzheaux merged commit 3ddf201 into spring-projects:main Jun 9, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jun 9, 2025

Thanks, @1livv! This is now merged into main. I also added fc7e6bced09827233a409148a5f9adc7fb5ec198 to update related documentation.

@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M1 Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants